-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sync Association resource to include sync metadata for all subkeys #2202
Conversation
@@ -77,8 +77,6 @@ resource "vault_secrets_sync_gh_destination" "test" { | |||
access_token = "%s" | |||
repository_owner = "%s" | |||
repository_name = "%s" | |||
app_name = "test-app-name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these from this test since these require additional setup in Vault and Secrets Sync for this to work, which was causing the test to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just my prior comments
…icorp/terraform-provider-vault into VAULT-25228/add-association-subkeys
LGTM! |
Description
Previously, the association resource did not account for the
secret-key
granularity, which would create a sync target for each subkey of a KV secret. Now, the association resource must keep track of the sync statuses for all subkeys of this associated secret.Notable improvements/changes:
metadata
which tracks the association metadata for each subkey (sync_status
,updated_at
)sync_status
andupdated_at
granularity
to all destination resources.Checklist
Output from acceptance testing: